GoldenEye: Source Forums

Debriefing => Bug Reports & Fixes => Topic started by: Graslu on June 09, 2014, 05:22:03 pm

Title: Massive fps drops with explosions
Post by: Graslu on June 09, 2014, 05:22:03 pm
This happens on any map, at any distance, and with any ammount of explosions. Seems like map optimization won't affect the explosion effect, even if you're in the jail of Bunker, you will still get fps drops from explosions occurring on the main room. Or in Facility Backzone while you're in the red room with armor you will get fps drops from explosions on the bottling room.

(http://i.imgur.com/1CrohX2.jpg)
(http://i.imgur.com/GfMXlJw.jpg)
(http://i.imgur.com/dyChEnq.jpg)

The first one is before any explosions, the  second one during one explosion on the main room, and the last one is one explosion in front of me. I never got less than 30fps with explosions, the fps are 30-100, with all the effects disabled, 60-100. This is really noticeable and annoying while playing, in aiming mainly. If I limit the fps to 150 (I normally have them limited at that), the fps drops are the same.

Here my PC specs (Playing at max settings, 1080p):
GPU - R9 280x 3GBvRAM
CPU - i7 3770 @ 3.4GHz with a max of 4.4GHz. 8 cores.
RAM - 8GB 1600MHz
Title: Re: Massive fps drops with explosions
Post by: kraid on June 09, 2014, 06:45:09 pm
Have you tried turning off "dynamic lights on explosions" in the advanced multiplayer options?
Title: Re: Massive fps drops with explosions
Post by: Graslu on June 09, 2014, 06:53:17 pm
Yes, the fps still drops to 60-100.
Title: Re: Massive fps drops with explosions
Post by: Entropy-Soldier on June 09, 2014, 10:27:50 pm
Next time we do a 1v1 I want timed mines to be in the set.  No reason.


But being serious, when we changed explosion effects in 4.1 they actually became a lot less intensive.  Even my dinky old PC could handle them fine.  Do you also get severe performance hits on maps with lots of particle effects, like the Perfect Dark: Source version of complex?
Title: Re: Massive fps drops with explosions
Post by: Jonathon [SSL] on June 09, 2014, 11:22:32 pm
I can vouch that this (original poster's issue) occurs. No idea why, though.
Title: Re: Massive fps drops with explosions
Post by: Entropy-Soldier on June 10, 2014, 12:58:22 am
Interesting.  I tested this using the same circumstances Graslu did and my FPS only hovered into the 100s when i detonated 10 mines right in front of myself with all the fancy effects on.  I actually only get 600 or so in that corridor when nothing's happening, so it's not nearly as colossal a drop.


However, there is certainly something going on here.  When i placed the same 10 mines in the control room and detonated them while standing in the cells, my FPS rapidly fell to 100 before climbing back up again at roughly the same rate.  I normally cap at 120, which explains why I've never noticed it before, but I've tested it on a few maps and the same thing seems to happen everywhere. 

I tested this with everything at max, but without HDR and motion blur.  I use an AMD Phenom 2 X4 965 processor with a Radeon HD 6850 card, so there's a bit of a difference there, but i can't say I've heard of anyone who runs Intel complaining of this problem.

Regardless, here's hoping we can narrow down the potential causes a bit, because this issue could be more widespread than first suspected.
Title: Re: Massive fps drops with explosions
Post by: soupcan on June 10, 2014, 01:20:28 am
but i can't say I've heard of anyone who runs Intel complaining of this problem.

I get this both on my desktop (AMD) and laptop (Intel + Nvidia).
Title: Re: Massive fps drops with explosions
Post by: killermonkey on June 10, 2014, 12:17:23 pm
Is it only on this map?
Title: Re: Massive fps drops with explosions
Post by: Graslu on June 10, 2014, 01:14:12 pm
Do you also get severe performance hits on maps with lots of particle effects, like the Perfect Dark: Source version of complex?
I get constant 150fps in Complex from PD:S, with explosions it drops to 70 or a bit less. I also noticed that it's not all of the explosions, seems like the ones close to walls or objects, not sure.
And I forgot to say, you get the drops when the fire effect is over and the smoke starts, at the end of the smoke you even get more drops, maybe that's why you didn't notice them when you exploded 10 mines in front of you, it takes some time, not sure if it's because the smoke effect or just that the fps counter have some seconds of delay. Oh and this happens in lowest settings too, though I didn't try to lower the resolution.
This happened to my old PC with a HD 5770 1GB, 4GB RAM, 32bit and a CPU of, I think, 1.8GHz, and Windows Vista. I'm using Windows 8.1 64 bit on this computer.

Is it only on this map?
No, I notice this in most of maps.
Title: Re: Massive fps drops with explosions
Post by: killermonkey on June 10, 2014, 01:36:29 pm
Here is how the explosion works:

1) A particle effect is started (its the whole sequence, fire and smoke, same effect)
2) 1 dynamic light is created
3) 1 sound effect is created
4) Every 1/3 seconds a check is performed to see if anything is within the damage area, if so it applies the appropriate amount of damage
5) After 4 seconds the smoke starts and the dynamic light and sound are shut off

This is why your report is confusing to me... all the hard work happens BEFORE the smoke!

Code: https://github.com/goldeneye-source/ges-code/blob/ges/game/server/ges/ent/ent_geexplosion.cpp#L129
Title: Re: Massive fps drops with explosions
Post by: Graslu on June 10, 2014, 01:48:58 pm
Then maybe it's just fps counter delay. I will try different ways to count them and edit this post. It's during the fire-near the end of it.
Title: Re: Massive fps drops with explosions
Post by: killermonkey on June 10, 2014, 03:57:42 pm
Do this:

Turn on cheats, then type in the console +showbudget
Then execute your normal explosion test that causes FPS drops
Take a screenshot of the budget display when you drop FPS

https://developer.valvesoftware.com/wiki/Showbudget
Title: Re: Massive fps drops with explosions
Post by: Graslu on June 10, 2014, 04:19:49 pm
http://cloud-2.steampowered.com/ugc/468686162965403989/68B6B139368C3B7E99C410354E85FB54FDF6F46C/
http://cloud-4.steampowered.com/ugc/468686162965409583/9F7797CF5AEC455C7B11CC9D187347ECC9AD93D8/
http://cloud-3.steampowered.com/ugc/468686162965407185/EEAD13D4E0A110E1A49206610DC2B1601CBD989B/
http://cloud-3.steampowered.com/ugc/468686162965411907/142E81D1279D27DB536089756C1853FE2D9D8A8D/

They're in order there, first 63, then 298, then back to 60+-, it's always like that.
Title: Re: Massive fps drops with explosions
Post by: killermonkey on June 10, 2014, 04:33:18 pm
OK so its clearly the particles causing the slow downs... now why particles rendered off-screen are causing slow downs is another issue entirely...
Title: Re: Massive fps drops with explosions
Post by: Graslu on June 10, 2014, 08:35:53 pm
Hopefully this gets fixed someday soon, it's really annoying to have those fps drops, while 60fps is good, only if it's constant. The change between playing at constant 150 to 60 and jumping between 30-100 becomes really noticeable and annoying for aiming and movement.