GoldenEye: Source Forums

  • April 13, 2024, 02:40:21 am
  • Welcome, Guest
Advanced search  

News:

Pages: [1]   Go Down

Author Topic: Changing GES Python's Style  (Read 4774 times)

0 Members and 1 Guest are viewing this topic.

killermonkey

  • GES Programmer
  • Retired Lead Developer
  • GE:S Fanatic
  • *
  • Posts: 5,473
  • Reputation Power: 346
  • killermonkey is awe-inspiring!killermonkey is awe-inspiring!killermonkey is awe-inspiring!killermonkey is awe-inspiring!killermonkey is awe-inspiring!killermonkey is awe-inspiring!killermonkey is awe-inspiring!killermonkey is awe-inspiring!killermonkey is awe-inspiring!killermonkey is awe-inspiring!killermonkey is awe-inspiring!killermonkey is awe-inspiring!
  • Offline Offline
    • DroidMonkey Apps
Changing GES Python's Style
« on: July 12, 2013, 10:35:11 pm »

I have been toying with the thought to completely overhaul the way GES Python is presented to the end-programmer... basically we do not conform to Python's style guides in any way: http://www.python.org/dev/peps/pep-0008

In particular, our CamelCase in packages, method names, and functions is highly frowned upon in Python.

http://www.python.org/dev/peps/pep-0008/#package-and-module-names
http://www.python.org/dev/peps/pep-0008/#function-names

Clearly this change would break everything that was custom coded instantly. That is why it would be reserved for the v4.3 release.

I want to know if the modding community would like to make this change? If you guys don't particular care, then it might not happen, but I am stickler for consistency and we have none at the moment.
Logged

Proxie

  • 00 Agent
  • ***
  • Posts: 573
  • Reputation Power: 141
  • Proxie is awe-inspiring!Proxie is awe-inspiring!Proxie is awe-inspiring!Proxie is awe-inspiring!Proxie is awe-inspiring!Proxie is awe-inspiring!Proxie is awe-inspiring!Proxie is awe-inspiring!Proxie is awe-inspiring!Proxie is awe-inspiring!Proxie is awe-inspiring!Proxie is awe-inspiring!
  • Offline Offline
Re: Changing GES Python's Style
« Reply #1 on: July 13, 2013, 05:55:19 am »

I vote yes for the change.  I can probably help out, too.
Logged

Troy

  • GE:S Coder
  • 00 Agent
  • ***
  • Posts: 821
  • Reputation Power: 260
  • Troy is awe-inspiring!Troy is awe-inspiring!Troy is awe-inspiring!Troy is awe-inspiring!Troy is awe-inspiring!Troy is awe-inspiring!Troy is awe-inspiring!Troy is awe-inspiring!Troy is awe-inspiring!Troy is awe-inspiring!Troy is awe-inspiring!Troy is awe-inspiring!
  • Offline Offline
Re: Changing GES Python's Style
« Reply #2 on: July 13, 2013, 08:14:11 am »

I suppose it would be a good idea conforming to the guide.  One thing I saw though was that imports should all be on separate lines.  That kind of seems like a waste of space if we had something like this:

Code: [Select]
import GEEntity, GEPlayer, GEUtil, GEWeapon, GEMPGameRules as GERules, GEGlobal as Glb
Logged
Complete - Arsenal, One Bullet is Enough, Tournament DM v2, TurboDM
Defunct - Agent Under Fire
VC - Being such a dick, KM must be stroked before springing into action.

killermonkey

  • GES Programmer
  • Retired Lead Developer
  • GE:S Fanatic
  • *
  • Posts: 5,473
  • Reputation Power: 346
  • killermonkey is awe-inspiring!killermonkey is awe-inspiring!killermonkey is awe-inspiring!killermonkey is awe-inspiring!killermonkey is awe-inspiring!killermonkey is awe-inspiring!killermonkey is awe-inspiring!killermonkey is awe-inspiring!killermonkey is awe-inspiring!killermonkey is awe-inspiring!killermonkey is awe-inspiring!killermonkey is awe-inspiring!
  • Offline Offline
    • DroidMonkey Apps
Re: Changing GES Python's Style
« Reply #3 on: July 13, 2013, 12:34:40 pm »

I don't agree with that one at all. Very wasteful. I've seen modules that conform to that and there header is longer than the script itself lol.
Logged
Pages: [1]   Go Up